Show toolbar and follow button for list visitor #9908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimchamp
requested changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks @schu96! This is working well, but there are two things that are bothering me:
- There are two sets of navigation breadcrumbs.
- The
databarViewmacro doesn't appear in the top-right corner of the view.
I've left some suggested code changes that will partially address number 2. In addition to those changes, you'll have to remove the breadcrumbs and the duplicate databarView, here.
jimchamp
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
jimchamp
added
the
Needs: Submitter Input
github-actions
bot
removed
the
Needs: Submitter Input
|
Whoops, thanks for the reminder I had a complete airhead moment there |
for more information, see https://pre-commit.ci
jimchamp
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Thanks @schu96, and sorry for the massive delay...
This is great! I'm going to switch things back such that the databarView isn't displayed for visitors, as there's not enough room for it and people can check the history table if they want to see the last edit date.
Will merge after I make the change and the tests pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9337
Fix
Technical
Remove
if/elsecondition, uses thelst['key']to determine if the user is the owner of the list and show relevant components within theaccount/view.htmltemplate.Testing
Followingtab.Screenshot
Stakeholders
@jimchamp